feat(web): add custom scripts plugin #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skierkowski
reviewed
Sep 24, 2024
| "license": "MIT", | ||
| "dependencies": { | ||
| "express": "^4.19.2", | ||
| "serverless-http": "^3.2.0" | ||
| }, | ||
| "devDependencies": { | ||
| "serverless-domain-manager": "^7.4.0", | ||
| "serverless-plugin-scripts": "^1.0.2" | ||
| "serverless-domain-manager": "^7.4.0" |
There was a problem hiding this comment.
This project uses npm workspaces, so don't forget to run npm i in the root to update the lock files.
skierkowski
reviewed
Sep 24, 2024
| @@ -0,0 +1,69 @@ | |||
| import { execSync } from "child_process"; | |||
|
|
|||
| class Scripts { | |||
There was a problem hiding this comment.
Can you add inline comments to provide more context for users who might not be familiar with plugins. A few things to cover...
- Why it exists - to run custom scripts, which we need to run the build script at deploy time, with support for variable resolution from framework, as well as proper stdio handling.
- How this works - it runs because it's included as a plugin in serverless.yml, and how hooks work.
skierkowski
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives us control over the child process running the script, so that we can suppress its output.